CI: Option to notarize macOS builds #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolve the merge conflicts with the other PR and i will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of it is fairly boilerplate stuff that you'll find by searching how to integrate signing/notarization into CI. Adds an input to the workflow that when checked, requires the following secrets:
APPLE_DEVID_APP_CERT_DATA: Your Developer ID Application certificate exported as P12 + base64 encoded
APPLE_DEVID_APP_CERT_PASS: The export password for that certificate
APPLE_ID_USER: Your Apple ID (i.e. email address)
APPLE_ID_PASS: Not your actual Apple password; rather an app-specific password
The openssl/grep/awk stuff is just some magic to detect the common name from the certificate instead of needing to have an additional pre-defined variable or secret for it.